Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:keploy CLI logs error message when command is unknown #1879

Merged

Conversation

khareyash05
Copy link
Contributor

Related Issue

  • Info about Issue or bug

Closes: #1853

Describe the changes you've made

Added functionality for logging out when command is unknown

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
Copy link

github-actions bot commented May 17, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@khareyash05
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@khareyash05
Copy link
Contributor Author

khareyash05 commented May 17, 2024

This will work for now. But a better way can be to check the command before it is executed. Maybe to iterate over the Registered map.

@charankamarapu
Copy link
Member

I think there will be a inbuilt feature in cobra to do this, please the tool once.

@khareyash05
Copy link
Contributor Author

I think there will be a inbuilt feature in cobra to do this, please the tool once.

on it!

Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charankamarapu charankamarapu merged commit 3077a9c into keploy:main May 31, 2024
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: no log incase of wrong commands
2 participants