Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for global passthrough in test mode #1920

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

gouravkrosx
Copy link
Member

@gouravkrosx gouravkrosx commented Jun 3, 2024

Related Issue

  • Support for global passthrough of external calls

Closes: #1919

Describe the changes you've made

  • Add a flag to disable mocking in test mode. You can use it like, keploy test -c "<appCMD>" --mocking=false
  • Move the Rerecord flag to only test in the cmd package.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Copy link
Member

@slayerjain slayerjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the repeating code. All looks fine to me.

Can we make the flag smaller and more intuitive? Maybe --mocking: false or something?

return nil
})
// read responses from destination
g.Go(func() error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make these method less repetitive?

The entire block below is repeating:

g.Go(func() error {
		defer pUtil.Recover(logger, client, nil)
		defer close(clientBuffChan)
		return nil
	})

Are these repeating elsewhere too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can make it less repetitive. This was referenced from the generic parser. I will make the changes in that file also.

Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Copy link
Member

@slayerjain slayerjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slayerjain slayerjain merged commit 81c0eec into main Jun 5, 2024
17 checks passed
@slayerjain slayerjain deleted the global-passthrough branch June 5, 2024 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support for global passthrough
2 participants