chore: kill docker container #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
gouravkrosx
reviewed
Jun 5, 2024
pkg/core/app/app.go
Outdated
| @@ -414,6 +414,34 @@ func (a *App) Run(ctx context.Context, inodeChan chan uint64) models.AppError { | |||
| } | |||
| return a.run(ctx) | |||
| } | |||
| func (a *App) getDockerMetaSync() { | |||
There was a problem hiding this comment.
Change this name, as it is not getting something and also don't mention sync, if it is a blocking call then it is already in sync.
There was a problem hiding this comment.
updated the same
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
gouravkrosx
reviewed
Jun 5, 2024
| containerID := a.container | ||
| for { | ||
| select { | ||
| case <-logTicker.C: |
There was a problem hiding this comment.
why is it needed when we're running it after context done? If we do so would be unable to inspect the docker as context is already cancelled.
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
shivamsouravjha
force-pushed
the
shivam/dockerKill
branch
from
b5159ef
to
7ece039
Compare
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
gouravkrosx
approved these changes
Jun 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Closes: #1904