-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes to allow running echo sql app in one go #102
Conversation
Signed-off-by: Himanshu Pandey <himanshu.dn.pandey@gmail.com>
Signed-off-by: Himanshu Pandey <himanshu.dn.pandey@gmail.com>
Signed-off-by: Himanshu Pandey <himanshu.dn.pandey@gmail.com>
31c3b4d
to
58f5ab1
Compare
Hey @hp77-creator, Since user can use its custom network as well , keploy will automatically use that network instead of using |
So i think, in this you can rename this to |
I see but on the docs that I was following,
I didn't get this. Do you want me to rename |
yea, that's true that if container name changes we have to change the host name but since service name is mapped we can consider using that. And at the docs it has been mention to run with docker run command. But above I was talking about docker-compose file only in case of docker compose even if you don't provide any network it will still work. Because keploy creates a |
Changes:
keploy-network
since that is whatkeploy
creates when we installkeploy
postgres
frompostgresDB
because docker uses service nameThere will be some changes that will need to be added in docs as well to ensure that user is able to run this app in one-go
Some suggestions like adding
--rm
command inkeploy record ...
command so that user doesn't see the error that container is still up/or change the app name.Open to suggestions. For now this also seemed good so sending a PR for the same.