This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
feat(ui): add pagination on test cases page #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy PR Preview failed. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: iamskp99 <iamskp99@gmail.com>
iamskp99
force-pushed
the
adding_pagination
branch
from
343ab15
to
ed3419c
Compare
iamskp99
changed the title
iamskp99
force-pushed
the
adding_pagination
branch
from
1027b75
to
8494520
Compare
|
The UI was showing the wrong total cases count if we query data in chunks. It is so because we are using the DataGrid module and it takes the total count as the count of the total test cases queried. So after talking with Shubham, we decided to query all the data in one go. |
iamskp99
force-pushed
the
adding_pagination
branch
from
8494520
to
7fd0f20
Compare
Signed-off-by: iamskp99 <iamskp99@gmail.com>
Signed-off-by: iamskp99 <iamskp99@gmail.com>
Signed-off-by: iamskp99 <iamskp99@gmail.com>
iamskp99
force-pushed
the
adding_pagination
branch
from
7fd0f20
to
ba8b3e4
Compare
|
LGTM! Found a couple of new good-first issues while reviewing this. Keep it up! 🎉 |
This was referenced Aug 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Added fix for the issue: keploy/keploy#367
Changed offset to 0 and limit to pageSize*(pageIndex+1)+1. The extra 1 ensures that the next arrow pointer is enabled.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: