Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

feat(ui): add onboarding guide for keploy #69

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

iamskp99
Copy link
Contributor

@iamskp99 iamskp99 commented Aug 26, 2022

Signed-off-by: iamskp99 iamskp99@gmail.com

Pull Request Template

Description

This PR is for this issue : keploy/keploy#371

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Deploy PR Preview failed.

@iamskp99 iamskp99 requested a review from nehagup August 26, 2022 10:24
Signed-off-by: iamskp99 <iamskp99@gmail.com>
Signed-off-by: iamskp99 <iamskp99@gmail.com>
Signed-off-by: iamskp99 <iamskp99@gmail.com>
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamskp99 The other dependency option shows an alert dialogue which is not helping with any information. So you can remove it in this PR and add a new PR where a request will be raised with Keploy.

For now you can also just provide "Create an Issue Github to add other Dependency" link at the bottom leading to respective SDKs issue creator link.

@iamskp99
Copy link
Contributor Author

Ok

Signed-off-by: iamskp99 <iamskp99@gmail.com>
@nehagup nehagup merged commit 60dce46 into keploy:main Aug 29, 2022
@ShivamTyagi12345 ShivamTyagi12345 added the hacktoberfest-accepted ready to review pull/merge requests, accepting those that are valid by merging them, leaving an over label Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted ready to review pull/merge requests, accepting those that are valid by merging them, leaving an over
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants