Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes banner for gittogether page w/signoff #38

Closed
wants to merge 4 commits into from

Conversation

chintanpuggalok
Copy link

changes the page for gittother with the given image

@chintanpuggalok chintanpuggalok marked this pull request as ready for review May 12, 2024 15:02
@chintanpuggalok
Copy link
Author

Fixes keploy/keploy#1866

@Hermione2408
Copy link
Member

Hey @chintanpuggalok thanks for making PR, but instead of replacing the whole background only gittogether image should be replaced with the following image

Signed-off-by: chintanpuggalok <chintanpuggalok@gmail.com>
@chintanpuggalok
Copy link
Author

@Hermione2408 is this better
image

@Sonichigo
Copy link
Member

Sonichigo commented May 15, 2024

Hey @chintanpuggalok , the banner is not aligned properly yet. We have a video in the background then above the logo of the event, the image would replace both of them so it's center aligned.

image

This part needs to be changed as a whole
cc: - @Hermione2408

@nehagup
Copy link
Member

nehagup commented May 23, 2024

@chintanpuggalok still working on this?

@chintanpuggalok
Copy link
Author

let me try

@chintanpuggalok
Copy link
Author

Does this seem okay?
image

@Sonichigo
Copy link
Member

Hey @chintanpuggalok , the banner is not aligned properly yet. We have a video in the background then above the logo of the event, the image would replace both of them so it's center aligned.

image This part needs to be changed as a whole cc: - @Hermione2408

hey @chintanpuggalok i have already mentioned the acceptable solution above. Please refer to this.

@nehagup
Copy link
Member

nehagup commented Jun 3, 2024

Closing this since it's stale. Please feel free to reopen.

@nehagup nehagup closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants