reviewdog [github-pr-review] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (63)
internal/dynatrace/entities_client_test.go|23 col 15| Error return value of writer.Write
is not checked (errcheck)
internal/sli/metrics/query_test.go|10 col 7| type args
is unused (unused)
internal/sli/v1/metrics/legacy_query_parser.go|117 col 6| type legacyEntitySelectorKeyValidator
is unused (unused)
internal/sli/v1/metrics/legacy_query_parser.go|120 col 44| func (*legacyEntitySelectorKeyValidator).ValidateKey
is unused (unused)
internal/sli/unit/units.go|25 col 6| func canBeConverted
is unused (unused)
internal/dynatrace/problems_v2_client.go|63 col 6| type problem
is unused (unused)
internal/action/deployment_finished_event_handler_test.go|55 col 38| func deploymentFinishedTestSetup.createHandlerAndTeardown
is unused (unused)
internal/action/deployment_finished_event_handler_test.go|106 col 6| type deploymentFinishedEventData
is unused (unused)
internal/action/test_helper_test.go|197 col 6| type baseEventData
is unused (unused)
internal/action/test_helper_test.go|22 col 7| const testKeptnShContext
is unused (unused)
internal/action/test_helper_test.go|134 col 6| func createDynatraceClient
is unused (unused)
internal/action/test_helper_test.go|254 col 6| func newKeptnCredentialsProviderMock
is unused (unused)
internal/action/deployment_finished_event_handler_test.go|75 col 38| func deploymentFinishedTestSetup.createExpectedDynatraceEvent
is unused (unused)
internal/action/test_helper_test.go|27 col 7| const testKeptnsBridge
is unused (unused)
internal/action/test_helper_test.go|148 col 6| func addLabelsToProperties
is unused (unused)
internal/action/deployment_finished_event_handler_test.go|102 col 38| func deploymentFinishedTestSetup.createEventPayloadContainer
is unused (unused)
internal/action/deployment_finished_event_handler_test.go|112 col 39| func (*deploymentFinishedEventData).GetTime
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|21 col 38| func evaluationFinishedTestSetup.createHandlerAndTeardown
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|73 col 6| type evaluationFinishedEventData
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|43 col 38| func evaluationFinishedTestSetup.createExpectedDynatraceEvent
is unused (unused)
internal/action/test_helper_test.go|28 col 7| const testEvaluationHeatmapURL
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|69 col 38| func evaluationFinishedTestSetup.createEventPayloadContainer
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|82 col 39| func (*evaluationFinishedEventData).GetEvaluationScore
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|85 col 39| func (*evaluationFinishedEventData).GetResult
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|88 col 39| func (*evaluationFinishedEventData).GetStartTime
is unused (unused)
internal/action/evaluation_finished_event_handler_test.go|91 col 39| func (*evaluationFinishedEventData).GetEndTime
is unused (unused)
internal/action/release_triggered_event_handler_test.go|21 col 36| func releaseTriggeredTestSetup.createHandlerAndTeardown
is unused (unused)
internal/action/release_triggered_event_handler_test.go|69 col 6| type releaseTriggeredEventData
is unused (unused)
internal/action/release_triggered_event_handler_test.go|39 col 36| func releaseTriggeredTestSetup.createExpectedDynatraceEvent
is unused (unused)
internal/action/release_triggered_event_handler_test.go|65 col 36| func releaseTriggeredTestSetup.createEventPayloadContainer
is unused (unused)
internal/action/release_triggered_event_handler_test.go|75 col 36| func releaseTriggeredEventData.GetResult
is unused (unused)
internal/action/test_finished_event_handler_test.go|20 col 32| func testFinishedTestSetup.createHandlerAndTeardown
is unused (unused)
internal/action/test_finished_event_handler_test.go|36 col 32| func testFinishedTestSetup.createExpectedDynatraceEvent
is unused (unused)
internal/action/test_finished_event_handler_test.go|62 col 32| func testFinishedTestSetup.createEventPayloadContainer
is unused (unused)
internal/action/test_helper_test.go|30 col 7| const testDynatraceAPIToken
is unused (unused)
internal/action/test_helper_test.go|142 col 6| func createDynatraceCredentials
is unused (unused)
internal/action/test_helper_test.go|212 col 25| func (*baseEventData).GetShKeptnContext
is unused (unused)
internal/action/test_helper_test.go|216 col 25| func (*baseEventData).GetEvent
is unused (unused)
internal/action/test_helper_test.go|220 col 25| func (*baseEventData).GetSource
is unused (unused)
internal/action/test_helper_test.go|224 col 25| func (*baseEventData).GetProject
is unused (unused)
internal/action/test_helper_test.go|228 col 25| func (*baseEventData).GetStage
is unused (unused)
internal/action/test_helper_test.go|232 col 25| func (*baseEventData).GetService
is unused (unused)
internal/action/test_helper_test.go|236 col 25| func (*baseEventData).GetDeployment
is unused (unused)
internal/action/test_helper_test.go|240 col 25| func (*baseEventData).GetTestStrategy
is unused (unused)
internal/action/test_helper_test.go|244 col 25| func (*baseEventData).GetDeploymentStrategy
is unused (unused)
internal/action/test_helper_test.go|248 col 25| func (*baseEventData).GetLabels
is unused (unused)
internal/action/test_triggered_event_handler_test.go|20 col 33| func testTriggeredTestSetup.createHandlerAndTeardown
is unused (unused)
internal/action/test_triggered_event_handler_test.go|37 col 33| func testTriggeredTestSetup.createExpectedDynatraceEvent
is unused (unused)
internal/action/test_triggered_event_handler_test.go|63 col 33| func testTriggeredTestSetup.createEventPayloadContainer
is unused (unused)
internal/sli/get_sli_triggered_event_handler_retrieve_metrics_from_dashboard_test.go|237 col 6| type uploadSLOsWillFailConfigClientMock
is unused (unused)
internal/sli/get_sli_triggered_event_handler_retrieve_metrics_from_dashboard_test.go|241 col 46| func (*uploadSLOsWillFailConfigClientMock).GetSLIs
is unused (unused)
internal/sli/dashboard/markdown_tile_processing.go|163 col 13| S1007: should use raw string (...
) with regexp.MustCompile to avoid having to escape twice (gosimple)
internal/sli/dashboard/slo_definition_parsing.go|167 col 13| S1007: should use raw string (...
) with regexp.MustCompile to avoid having to escape twice (gosimple)
internal/credentials/keptn_credentials_reader_test.go|154 col 12| S1005: unnecessary assignment to the blank identifier (gosimple)
internal/context/triggered_timeout_context_test.go|24 col 14| S1012: should use time.Since
instead of time.Now().Sub
(gosimple)
internal/context/triggered_timeout_context_test.go|42 col 14| S1012: should use time.Since
instead of time.Now().Sub
(gosimple)
internal/context/triggered_timeout_context_test.go|61 col 14| S1012: should use time.Since
instead of time.Now().Sub
(gosimple)
internal/sli/result/summarizer.go|30 col 6| S1002: should omit comparison to bool constant, can be simplified to !sliResult.Success
(gosimple)
internal/monitoring/metric_events_creation.go|198 col 2| S1021: should merge variable declaration with assignment on next line (gosimple)
internal/monitoring/metric_events_creation.go|65 col 6| ineffectual assignment to mzId (ineffassign)
internal/rest/rest_client.go|7 col 2| SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
internal/test/file_based_url_handler.go|4 col 2| SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
internal/test/file_based_url_handler_with_sink.go|5 col 2| SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)