API: Get Event returns HTTP 500 when event cant be found. Should be 404

[grabnerandi]

When waiting for an evaluation-done event a client has to call GET /event with the keptnContext and evaluation-done as event type. When the event does not yet exists the Keptn API returns an HTTP 500 (Internal Server Error) instead of something that is more descriptive, e.g: 404 Resource Not Found.

HTTP 500 is definitely misleading as this is not an internal server error. It is really about an event not being present - so - a more suitable HTTP Status Code should be used, e.g: 404

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[imrenagi]

I will take this

[johannes-b]

The /GET event endpoint still returns a 500 - Internal Server error, because the GetEvent function returns an error which leads to the 500 error.

Task:

• Change the getLatestEvent (in mongodb-datastore) to return a 404 when no event with the given keptnContext and type is available

Definition of Done:

• The /GET event endpoint returns 404 (resource not found) when the event from the given keptnContext and type is not available.