Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Return 404 when no event is found in /event endpoint #2114

Merged
merged 1 commit into from Jul 28, 2020
Merged

Return 404 when no event is found in /event endpoint #2114

merged 1 commit into from Jul 28, 2020

Conversation

imrenagi
Copy link
Contributor

Resolving #1655

Signed-off-by: Imre Nagi imre.nagi2812@gmail.com

@imrenagi
Return 404 when no event is found in /event endpoint
7621714 
Signed-off-by: Imre Nagi <imre.nagi2812@gmail.com>
@agrimmer
Copy link
Member

I will test the PR tomorrow.

@johannes-b johannes-b linked an issue Jul 28, 2020 that may be closed by this pull request
API: Get Event returns HTTP 500 when event cant be found. Should be 404 #1655
Closed
@agrimmer
Copy link
Member

lgtm
But we need to leave the issue #1655 open because we also need to address this in the mongodb-datastore.

@agrimmer agrimmer merged commit 310e808 into keptn:master Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christian-kreuzberger-dtx christian-kreuzberger-dtx Awaiting requested review from christian-kreuzberger-dtx

@johannes-b johannes-b Awaiting requested review from johannes-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Get Event returns HTTP 500 when event cant be found. Should be 404
2 participants
@imrenagi @agrimmer