Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

After keptn configure domain, an already exposed bridge is no longer accessible #1752

Closed
christian-kreuzberger-dtx opened this issue May 5, 2020 · 0 comments · Fixed by #1874
Assignees
Labels
area:istio help wanted Extra attention is needed type:bug Something is not working as intended/documented
Milestone

Comments

@christian-kreuzberger-dtx
Copy link
Member

christian-kreuzberger-dtx commented May 5, 2020

Steps to reproduce:

  1. Install Keptn 0.6.2 (full installation)
  2. expose bridge using keptn configure bridge --action=expose - bridge is exposed at (e.g.) bridge.keptn.1.2.3.4.xip.io
  3. change domain using keptn configure domain 1.2.3.4.nip.io
  4. Try to access bridge using the new domain https://bridge.keptn.1.2.3.4.nip.io (does not work)

Interesting enough, the old domain (using xip.io) still works for Keptn's bridge.

Some more data

$ kk get vs
NAME     GATEWAYS                        HOSTS                                             AGE
api      [public-gateway.istio-system]   [api.keptn.1.2.3.4.nip.io api.keptn]   4m50s
bridge   [public-gateway.istio-system]   [bridge.keptn.1.2.3.4.xip.io]                131m

Work-around

Right now, the user has to execute the following commands to make the setup work again:

keptn configure bridge --action=lockdown
keptn configure bridge --action=expose

Possible Fix

I guess one of the two following variants should work:

  • keptn configure domain should output a warning, that the user needs to manually check and update all other virtual services (e.g., bridge, but also onboarded services)
  • keptn configure domain needs to also update other virtual services, not just the API vs (which is handled via a kubectl apply).

Please note, I did not check if this also happens when using nginx-ingress (e.g., when using the quality-gates installation), but I guess nginx-ingress is handling this differently

@christian-kreuzberger-dtx christian-kreuzberger-dtx added type:bug Something is not working as intended/documented area:istio help wanted Extra attention is needed labels May 5, 2020
@johannes-b johannes-b added this to the 0.7.0 milestone May 20, 2020
@johannes-b johannes-b added the next-sprint Items that should be discussed and implemented in the next sprint label May 27, 2020
@bacherfl bacherfl self-assigned this Jun 3, 2020
@johannes-b johannes-b removed the next-sprint Items that should be discussed and implemented in the next sprint label Jun 4, 2020
bacherfl added a commit that referenced this issue Jun 5, 2020
* #1796 keep NodePort in ConfigMap when configure domain is used

* #1796 added sanitation for user input

* #1752 added log messages related to reuse of existing NodePort
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:istio help wanted Extra attention is needed type:bug Something is not working as intended/documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants