Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Return Git commit ID in finished events sent by helm-service #2531

Closed
johannes-b opened this issue Oct 13, 2020 · 0 comments · Fixed by #2624
Closed

Return Git commit ID in finished events sent by helm-service #2531

johannes-b opened this issue Oct 13, 2020 · 0 comments · Fixed by #2624
Assignees
@warber
Labels
area:gitops Everything related to our GitOps approach
Milestone
0.8.0

Comments

@johannes-b
Copy link
Member

A missing piece in the PR: #2502 of the helm-service is that the finished events do not contain the Git-hash as introduced in #2307

Task:

  • Extend the helm-service to return the Git commit ID in the finished events sent out by the service
@johannes-b johannes-b added area:gitops Everything related to our GitOps approach kep:06 labels Oct 13, 2020
@johannes-b johannes-b added this to the 0.8.0 milestone Oct 13, 2020
@johannes-b johannes-b added the next-sprint Items that should be discussed and implemented in the next sprint label Oct 15, 2020
@johannes-b johannes-b removed the next-sprint Items that should be discussed and implemented in the next sprint label Oct 23, 2020
warber added a commit that referenced this issue Nov 2, 2020
@warber
#2531: adapt GetUserChart and mocked onboarder
975b826
warber added a commit that referenced this issue Nov 2, 2020
@warber
#2531: adapted kubernetes utils dependency
a3e4b85
warber added a commit that referenced this issue Nov 2, 2020
@warber
#2531: enhanced test
39bfa42
warber added a commit that referenced this issue Nov 2, 2020
@warber
#2531: refer to kuberenetes-utils master
60f62f4
@warber warber mentioned this issue Nov 2, 2020
Merged
warber added a commit that referenced this issue Nov 2, 2020
@warber
#2531: appease reviewdog
9b98177
warber added a commit that referenced this issue Nov 2, 2020
@warber
#2531: appease reviewdog II
b69c2dc
warber added a commit that referenced this issue Nov 2, 2020
@warber
#2531: appease reviewdog III
68cf760
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@warber warber

Labels
area:gitops Everything related to our GitOps approach
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Bug/2531/helm service return commit keptn/keptn
2 participants
@johannes-b @warber