Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Show Shipyard Version in Keptn Bridge #2909

Closed
christian-kreuzberger-dtx opened this issue Jan 14, 2021 · 2 comments · Fixed by #3200
Closed

Show Shipyard Version in Keptn Bridge #2909

christian-kreuzberger-dtx opened this issue Jan 14, 2021 · 2 comments · Fixed by #3200
Assignees
Labels
bridge.2.0 Bridge Version 2 type:improvement Improves/enhances an existing feature

Comments

@christian-kreuzberger-dtx
Copy link
Member

Now that #2804 has been implemented and merged, we could show the shipyard version in Keptn Bridge, e.g., on the main screen:
image

FYI @ermin-muratovic @johannes-b please decide whether this makes sense and where to put this information.

@christian-kreuzberger-dtx christian-kreuzberger-dtx added bridge.2.0 Bridge Version 2 type:improvement Improves/enhances an existing feature ready-for-refinement Issue is relevant for the next backlog refinment labels Jan 14, 2021
@johannes-b johannes-b added this to the 0.8.1 (Bridge) milestone Jan 18, 2021
@johannes-b
Copy link
Member

johannes-b commented Feb 2, 2021

This is a great idea to help users migrating from 0.7.x to 0.8.0.

I propose to add this information to the project tile since we have no other way of managing project-specific config yet. In the future, a settings page where we manage the Git-upstream would be the right place to deal with the shipyard version.

For now, I propose the following:

image

Validation of Shipyard version: As indicated by the mockup, a validation of the shipyard version is conducted. If the version < 0.2.x -> the project name is red and a note is displayed on how to upgrade the shipyard

@johannes-b
Copy link
Member

johannes-b commented Feb 2, 2021

In the meta-data of Keptn, mock (hard-coded) the currently supported spec version (in https://github.com/keptn/keptn/blob/master/api/handlers/metadata.go ). Use this information to perform the validation in the UI.

@johannes-b johannes-b added next-sprint Items that should be discussed and implemented in the next sprint and removed ready-for-refinement Issue is relevant for the next backlog refinment labels Feb 2, 2021
@johannes-b johannes-b linked a pull request Feb 5, 2021 that will close this issue
@johannes-b johannes-b removed a link to a pull request Feb 5, 2021
@Kirdock Kirdock self-assigned this Feb 8, 2021
@johannes-b johannes-b removed the next-sprint Items that should be discussed and implemented in the next sprint label Feb 8, 2021
Kirdock added a commit that referenced this issue Feb 10, 2021
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Kirdock added a commit that referenced this issue Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bridge.2.0 Bridge Version 2 type:improvement Improves/enhances an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants