Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Show task details in sequence details #2938

Closed
ermin-muratovic opened this issue Jan 19, 2021 · 2 comments · Fixed by #3030
Closed

Show task details in sequence details #2938

ermin-muratovic opened this issue Jan 19, 2021 · 2 comments · Fixed by #3030
Assignees
@ermin-muratovic
Labels
bridge:sequence-screen bridge.2.0 Bridge Version 2
Milestone
0.8.0 (Bridge)

Comments

@ermin-muratovic
Copy link
Member

ermin-muratovic commented Jan 19, 2021 •
edited
Loading

When clicking on a sequence, the details are displayed next to the sequence list.
Each step/task in the sequence may contain different details, which should be display here. Also the status (success/failed) should be easily visible and the error message should be displayed properly.

Component behavior:

  • Display steps/task which have been executed in the selected stage.
  • If the step/task is still active, show a loading icon
  • If the step/task is finished, show all details that are provided in the payload in an expandable tile
    • All triggered services and the status of the finished event
    • Show error message if status failed
    • Show the result if status is successful

100993577-df503500-3555-11eb-8345-ff2620e5e787-seqdetails
@ermin-muratovic ermin-muratovic mentioned this issue Jan 19, 2021
Closed
@christian-kreuzberger-dtx
Copy link
Member

On the right side it says "2 services triggered", I'm wondering if we should call it "triggered", or if we just say "2 services have reacted" or just "2 services".

Reasoning (please correct me if I am wrong here):
In Keptn 0.8.x, we don't actually trigger multiple services, instead it is possible that multiple services return a .started and .status.changed and .finished event.

@johannes-b johannes-b added this to the 0.8.0 (Bridge) milestone Jan 19, 2021
@johannes-b johannes-b added the ready-for-refinement Issue is relevant for the next backlog refinment label Jan 19, 2021
@johannes-b johannes-b mentioned this issue Jan 19, 2021
Closed
@johannes-b
Copy link
Member

johannes-b commented Jan 19, 2021 •
edited
Loading

Is part of: #2627

I agree with Christian that we should not display "triggered" (this is a technical detail). Let's go with: "x services reacted"

@johannes-b johannes-b added next-sprint Items that should be discussed and implemented in the next sprint and removed ready-for-refinement Issue is relevant for the next backlog refinment labels Jan 19, 2021
@ermin-muratovic ermin-muratovic self-assigned this Jan 21, 2021
@ermin-muratovic ermin-muratovic removed the next-sprint Items that should be discussed and implemented in the next sprint label Jan 21, 2021
@ermin-muratovic ermin-muratovic linked a pull request Jan 28, 2021 that will close this issue
#2938 Show task details in sequence details #3030
Merged
ermin-muratovic added a commit that referenced this issue Feb 10, 2021
@ermin-muratovic @Kirdock @christian-kreuzberger-dtx
#2938 Show task details in sequence details (#3030)
3ca6585 
* create component for sequence overview, sequence list and task details

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* change model to valuesCanary

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* show sequence tasks filtered by stage and show progress details in tiles

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* show message in task details

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* fix DateUtil import in mock-data

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* fixed confirmation dialog of approval

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* Update unit tests

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* trigger changedetector on reload

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* create environment-view component

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* directory change, environment layout adjustment

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* #2824 Added cache for CI workflow

Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>

* remove duplicate stage info

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* allow expandable to be "warning", "highlighted", "disabled" and selected

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* move subtask details to task-item and add details (payload) and separator

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* highlight selected stage in timeline

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* Highlight whole stage info in timeline

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* fix tests for sh.keptn.event.dev.artifact-delivery.triggered

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* consider result from ".finished" event

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* get deploymentURI from ".finished" event

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* #2943 Create stage-overview component

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* create integration-view component

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>

* if event itself is .finished, return this

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* rename ktb-sequence-overview into ktb-sequence-view (align with other views)

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* hide dt-tag if no imageName or serviceName provided

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* show sequence-view when sequence tab selected

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* hide stage timeline if no stages available

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* align 'show-more' button from top

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* show approval-item if task is a pending approval

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* rename sequence-overview to sequence-view (align with other views)

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* enivornment-view reduced

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* merge changes from master

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* show loading indicator only if ".started" event is available, but not yet ".finished"

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* store started in this.started

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* represent states in expandable-tile like in selectable-tile

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* Reload button not as dt-tag

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* align icon and label

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

Co-authored-by: Klaus Strießnig <k.striessnig@gmail.com>
Co-authored-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ermin-muratovic ermin-muratovic

Labels
bridge:sequence-screen bridge.2.0 Bridge Version 2
Projects
None yet
Milestone
0.8.0 (Bridge)
Development

Successfully merging a pull request may close this issue.

#2938 Show task details in sequence details keptn/keptn
3 participants
@johannes-b @ermin-muratovic @christian-kreuzberger-dtx