Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

go-utils and keptn cli: Remove outdated xip.io resolver #3058

Closed
3 tasks
christian-kreuzberger-dtx opened this issue Feb 3, 2021 · 0 comments · Fixed by #3059
Closed
3 tasks

go-utils and keptn cli: Remove outdated xip.io resolver #3058

christian-kreuzberger-dtx opened this issue Feb 3, 2021 · 0 comments · Fixed by #3059
Assignees
@christian-kreuzberger-dtx
Labels
area:cli area:go-utils type:chore Provides value to the (dev) team
Projects
Working items
Milestone
0.8.0

Comments

@christian-kreuzberger-dtx
Copy link
Member

Back with Keptn 0.6.x we had issues when it came to resolving the DNS of e.g. 1.2.3.4.xip.io. Hence we have introduced this:
https://github.com/keptn/go-utils/blob/e1597de1663e9b72bf0e95d725284c162bc65a85/pkg/api/utils/xipIoResolver.go

This was especially helpful for integration tests, but also for workshops.

Nowadays we don't rely on xip.io anymore (if anything, we use the direct IP address or nip.io - see tutorials and examples.

Definition of Done

  • Removed ResolveXipIoWithContext from go-utils
  • Removed usage of ResolveXipIoWithContext in keptn core (mainly in CLI)
  • Keptn CLI still works when authenticating, sending events, and other api calls
@christian-kreuzberger-dtx christian-kreuzberger-dtx added this to the 0.8.0 milestone Feb 3, 2021
@christian-kreuzberger-dtx christian-kreuzberger-dtx added this to Backlog in Working items via automation Feb 3, 2021
@christian-kreuzberger-dtx christian-kreuzberger-dtx moved this from Backlog to In progress in Working items Feb 3, 2021
Merged
Merged
christian-kreuzberger-dtx added a commit that referenced this issue Feb 3, 2021
@christian-kreuzberger-dtx
#3058 Remove XipIoResolver
6156b53 
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
christian-kreuzberger-dtx added a commit that referenced this issue Feb 4, 2021
@christian-kreuzberger-dtx
Merge pull request #3059 from keptn/feature/3058/remove_xip_io
94d7c03 
#3058 Remove XipIoResolver
@johannes-b johannes-b moved this from In progress to Ready for review in Working items Feb 4, 2021
@johannes-b johannes-b moved this from Ready for review to Done/presented in community review (column will be cleaned regularly) in Working items Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christian-kreuzberger-dtx christian-kreuzberger-dtx

Labels
area:cli area:go-utils type:chore Provides value to the (dev) team
Projects
No open projects
Working items
Done/presented in community review (c...
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

#3058 Remove XipIoResolver keptn/keptn
1 participant
@christian-kreuzberger-dtx