Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

#3058 Remove XipIoResolver #3059

Merged
merged 1 commit into from Feb 4, 2021

Conversation

christian-kreuzberger-dtx
Copy link
Member

Signed-off-by: Christian Kreuzberger christian.kreuzberger@dynatrace.com

Fixes #3058

I've removed it in go-utils as well, see keptn/go-utils#237

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #3059 (c9fe743) into master (5caa98f) will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3059      +/-   ##
==========================================
- Coverage   37.29%   36.63%   -0.66%     
==========================================
  Files         171      169       -2     
  Lines       10182     9812     -370     
  Branches      228      228              
==========================================
- Hits         3797     3595     -202     
+ Misses       5805     5671     -134     
+ Partials      580      546      -34     
Flag Coverage Δ *Carryforward flag
api 29.64% <ø> (ø) Carriedforward from e92c357
bridge 21.89% <ø> (ø) Carriedforward from e92c357
cli 37.98% <ø> (-0.05%) ⬇️
configuration-service 31.25% <ø> (ø) Carriedforward from e92c357
distributor-service ?
gatekeeper-service 84.61% <ø> (ø) Carriedforward from e92c357
helm-service 39.68% <ø> (ø) Carriedforward from e92c357
jmeter-service 10.84% <ø> (ø) Carriedforward from e92c357
lighthouse-service 48.54% <ø> (ø) Carriedforward from e92c357
mongodb-datastore 22.05% <ø> (ø) Carriedforward from e92c357
openshift-route-service 33.82% <ø> (ø) Carriedforward from e92c357
remediation-service 59.26% <ø> (ø) Carriedforward from e92c357
shipyard-controller 43.91% <ø> (ø) Carriedforward from e92c357
statistics-service 55.31% <ø> (ø) Carriedforward from e92c357

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
cli/cmd/check_endpoint_status.go 83.33% <ø> (ø)
cli/cmd/configure_bridge.go 55.40% <ø> (-1.18%) ⬇️
distributor/cmd/main.go
distributor/pkg/lib/nats_connection_handler.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5caa98f...6156b53. Read the comment docs.

Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

The following Docker Images have been built:

  • No images have been built or uploaded

@christian-kreuzberger-dtx christian-kreuzberger-dtx merged commit 94d7c03 into master Feb 4, 2021
@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the feature/3058/remove_xip_io branch February 4, 2021 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-utils and keptn cli: Remove outdated xip.io resolver
2 participants