Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Allow comma-separated list on event filters for distributors #3577

Closed
2 tasks
johannes-b opened this issue Mar 19, 2021 · 0 comments · Fixed by #3579
Closed
2 tasks

Allow comma-separated list on event filters for distributors #3577

johannes-b opened this issue Mar 19, 2021 · 0 comments · Fixed by #3579
Assignees
Labels
area:core good first issue Issues for getting started developing Keptn help wanted Extra attention is needed Keptn-on-Keptn Everything related deploying Keptn and testing Keptn with Keptn
Milestone

Comments

@johannes-b
Copy link
Member

johannes-b commented Mar 19, 2021

Use-Case:

image

For implementing the above use-case, I need two helm-services: (1) works on control-plane and deploys on development, hardening, production; (2) works on execution-plane and deploys on production-remote

Limitation: Filters on the distributor just allow a single value.

Improvement: As a user, I would like to configure my distributor to listen to events, e.g., for multiple stages. In the example below, I would like to get events for the dev and hardening stage:

distributor:
  projectFilter: ""                 
  stageFilter: "development,hardening,production"             
  serviceFilter: ""                     

Implementation details:

Definition of Done:

@johannes-b johannes-b added area:core good first issue Issues for getting started developing Keptn help wanted Extra attention is needed ready-for-refinement Issue is relevant for the next backlog refinment labels Mar 19, 2021
@johannes-b johannes-b added this to the 0.8.2 milestone Mar 19, 2021
@johannes-b johannes-b modified the milestones: 0.8.2, 0.8.1 Mar 19, 2021
johannes-b added a commit that referenced this issue Mar 19, 2021
Signed-off-by: Johannes <johannes.braeuer@dynatrace.com>
@johannes-b johannes-b self-assigned this Mar 19, 2021
@johannes-b johannes-b added Keptn-on-Keptn Everything related deploying Keptn and testing Keptn with Keptn and removed ready-for-refinement Issue is relevant for the next backlog refinment labels Mar 19, 2021
johannes-b added a commit that referenced this issue Mar 19, 2021
…3579)

* #3577 Allow a comma-separated list of values for distributor filters

* #3577 Replaced contains function with check if the element is in a slice

Signed-off-by: Johannes <johannes.braeuer@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:core good first issue Issues for getting started developing Keptn help wanted Extra attention is needed Keptn-on-Keptn Everything related deploying Keptn and testing Keptn with Keptn
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant