secret-service should not throw a 500 status code if there are too many characters for the secret name or key #5479

Kirdock · 2021-10-04T12:59:06Z

If a secret name or secret key with more than 253 characters is created or updated (POST /secret and PUT /secret), the secret service returns a 500 instead of a 400 status code.

Further endpoints could be affected by the same issue.

The text was updated successfully, but these errors were encountered:

changed handler so that too big name or key returns httpstatus 400 Signed-off-by: RealAnna <anna.reale@dynatrace.com>

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

* fix(secret-service): changed too big key or name status (#5479) changed handler so that too big name or key returns httpstatus 400 Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): meaningful error message (#5479) Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): moved error handling to k8s backend Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): reviewed backend test Signed-off-by: RealAnna <anna.reale@dynatrace.com>

…eptn#5631) * fix(secret-service): changed too big key or name status (keptn#5479) changed handler so that too big name or key returns httpstatus 400 Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): meaningful error message (keptn#5479) Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): moved error handling to k8s backend Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): reviewed backend test Signed-off-by: RealAnna <anna.reale@dynatrace.com> Signed-off-by: Gevorg Iskandaryan <gevorg.iskandaryan@dynatrace.com>

Kirdock added type:bug Something is not working as intended/documented area:core ready-for-refinement Issue is relevant for the next backlog refinment labels Oct 4, 2021

Kirdock added this to Ready for refinement in Refinement board Oct 4, 2021

thisthat modified the milestones: 0.11.0 (Bridge), 0.11.0 Oct 5, 2021

thisthat assigned RealAnna Oct 8, 2021

johannes-b changed the title ~~Secret service should not throw a 500 status code if there are too many characters for the secret name or key~~ secret-service should not throw a 500 status code if there are too many characters for the secret name or key Oct 11, 2021

thisthat modified the milestones: 0.11.0, 0.10.0 Oct 12, 2021

RealAnna added a commit that referenced this issue Oct 12, 2021

fix(secret-service): changed too big key or name status (#5479)

307ae2d

changed handler so that too big name or key returns httpstatus 400 Signed-off-by: RealAnna <anna.reale@dynatrace.com>

RealAnna mentioned this issue Oct 12, 2021

fix(secret-service): changed too big key or name status (#5479) #5631

Merged

RealAnna added a commit that referenced this issue Oct 12, 2021

fix(secret-service): meaningful error message (#5479)

884c57c

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

johannes-b removed the ready-for-refinement Issue is relevant for the next backlog refinment label Oct 12, 2021

RealAnna closed this as completed in #5631 Oct 13, 2021

johannes-b removed this from Ready for refinement in Refinement board Nov 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

secret-service should not throw a 500 status code if there are too many characters for the secret name or key #5479

secret-service should not throw a 500 status code if there are too many characters for the secret name or key #5479

Kirdock commented Oct 4, 2021 •

edited by thisthat

secret-service should not throw a 500 status code if there are too many characters for the secret name or key #5479

secret-service should not throw a 500 status code if there are too many characters for the secret name or key #5479

Comments

Kirdock commented Oct 4, 2021 • edited by thisthat

Kirdock commented Oct 4, 2021 •

edited by thisthat