This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(secret-service): changed too big key or name status (#5479) #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed handler so that too big name or key returns httpstatus 400 Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Codecov Report
@@ Coverage Diff @@
## master #5631 +/- ##
==========================================
- Coverage 55.12% 54.50% -0.63%
==========================================
Files 322 313 -9
Lines 18778 18484 -294
Branches 962 973 +11
==========================================
- Hits 10352 10074 -278
+ Misses 7519 7514 -5
+ Partials 907 896 -11
|
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Docker Build Report
|
bacherfl
approved these changes
Oct 13, 2021
carpe-github
pushed a commit
to carpe-github/keptn
that referenced
this pull request
Nov 4, 2021
…eptn#5631) * fix(secret-service): changed too big key or name status (keptn#5479) changed handler so that too big name or key returns httpstatus 400 Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): meaningful error message (keptn#5479) Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): moved error handling to k8s backend Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(secret-service): reviewed backend test Signed-off-by: RealAnna <anna.reale@dynatrace.com> Signed-off-by: Gevorg Iskandaryan <gevorg.iskandaryan@dynatrace.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RealAnna anna.reale@dynatrace.com
This PR
Related Issues
Fixes #5479
Notes
Follow-up Tasks
How to test