Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Core: Lighthouse-service should return the evaluation result as part of the event payload #5496

Closed
4 tasks
thisthat opened this issue Oct 5, 2021 · 0 comments · Fixed by #6194
Closed
4 tasks

Core: Lighthouse-service should return the evaluation result as part of the event payload #5496

thisthat opened this issue Oct 5, 2021 · 0 comments · Fixed by #6194
Assignees
@RealAnna
Labels
area:core area:lighthouse type:improvement Improves/enhances an existing feature
Milestone
0.12.0

Comments

@thisthat
Copy link
Member

thisthat commented Oct 5, 2021 •
edited
Loading

Action Item

The lighthouse-service shall be changed to return the evaluation values used for calculation as a part of the event payload.

Technical Details

Currently, the lighthouse-service only returns the list of evaluation events used for the comparison under the comparedEvents property. To understand why an evaluation passes/fails, a user has to manually compute the comparison values which is an error-prone process.
The service should report the past value used for the SLO assessment as a new field with the name comparedValue.

DoD

  • The service annotates the finished event with the past evaluation value
  • Unit tests
  • Adapt integration tests
  • Spec update
@thisthat thisthat added area:core area:lighthouse ready-for-refinement Issue is relevant for the next backlog refinment type:improvement Improves/enhances an existing feature labels Oct 5, 2021
@thisthat thisthat added this to the 0.11.0 milestone Oct 5, 2021
@thisthat thisthat mentioned this issue Oct 5, 2021
Closed
2 tasks
@thisthat thisthat removed the ready-for-refinement Issue is relevant for the next backlog refinment label Oct 18, 2021
@thisthat thisthat modified the milestones: 0.11.0, 0.12.0 Nov 3, 2021
@RealAnna RealAnna self-assigned this Nov 24, 2021
This was referenced Nov 25, 2021
Merged
Merged
RealAnna added a commit that referenced this issue Dec 3, 2021
@RealAnna
feat(lighthouse-service): Add compared value to payload (#5496) (#6194)
f5af13c 
* feat: refactored sli_handler to return comparedValue

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

* feat: refactored sli_handler to return comparedValue

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

* feat: added unit test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

* feat: tiny fix

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

* feat: added compared value even inf there is no comparison

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RealAnna RealAnna

Labels
area:core area:lighthouse type:improvement Improves/enhances an existing feature
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

feat(lighthouse-service): Add compared value to payload (#5496) keptn/keptn
2 participants
@thisthat @RealAnna