Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Bridge: Move the secret pickup into its own component #5733

Closed
2 tasks done
thisthat opened this issue Oct 18, 2021 · 0 comments · Fixed by #6099
Closed
2 tasks done

Bridge: Move the secret pickup into its own component #5733

thisthat opened this issue Oct 18, 2021 · 0 comments · Fixed by #6099
Assignees
@ermin-muratovic
Labels
bridge.2.0 Bridge Version 2 kep:54
Milestone
0.12.0 (Bridge)

Comments

@thisthat
Copy link
Member

thisthat commented Oct 18, 2021 •
edited by ermin-muratovic

Action Item

The secret pickup should be moved into its own component and accept a generic tree-like data structure.

image.png

Techincal details

Currently, it only supports two layers. This should be extended to be general.

DoD

  • Unit tests with custom tree-like data
  • The new component is implemented
@thisthat thisthat added bridge.2.0 Bridge Version 2 ready-for-refinement Issue is relevant for the next backlog refinment labels Oct 18, 2021
@thisthat thisthat added this to the 0.11.0 (Bridge) milestone Oct 18, 2021
This was referenced Oct 18, 2021
Closed
Closed
@thisthat thisthat removed the ready-for-refinement Issue is relevant for the next backlog refinment label Nov 9, 2021
@ermin-muratovic ermin-muratovic self-assigned this Nov 17, 2021
This was referenced Nov 17, 2021
Closed
Merged
ermin-muratovic added a commit that referenced this issue Nov 25, 2021
@ermin-muratovic
refactor(bridge): Move secret picker in own component (#5733) (#6099)
a54f6a7 
* move ktb-edit-service-file-list to _components

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* move secret selector to own component

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* change header text

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* test secret selector component

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* remove secret selector tests from webhook settings spec

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* remove unused imports

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* make secret selector a generic variable selector

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* make secret selector generic variable selector

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* map secrets

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* make dataSource for ktb-variable-selector generic

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* map secrets to SelectTreeNode in webhook settings

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* fix variable

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* make icon and aria-label configurable

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* set label for select secret button

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* use ng-template to reduce duplication

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* bind aria-label correctly

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* make iconName of type DtIconType

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ermin-muratovic ermin-muratovic

Labels
bridge.2.0 Bridge Version 2 kep:54
Projects
None yet
Milestone
0.12.0 (Bridge)
Development

Successfully merging a pull request may close this issue.

refactor(bridge): Move secret picker in own component (#5733) keptn/keptn
3 participants
@johannes-b @thisthat @ermin-muratovic