This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
refactor(bridge): Remove global project polling and remove project dependency in integrations view #8412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendency in integrations view Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8412 +/- ##
==========================================
+ Coverage 66.44% 66.88% +0.43%
==========================================
Files 612 613 +1
Lines 31915 31972 +57
Branches 1677 1683 +6
==========================================
+ Hits 21207 21384 +177
+ Misses 9415 9301 -114
+ Partials 1293 1287 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Striessnig <k.striessnig@gmail.com>
heinzburgstaller
suggested changes
Jul 18, 2022
bridge/client/app/_views/ktb-environment-view/ktb-stage-details/ktb-stage-details.component.ts
Outdated
Show resolved
Hide resolved
...ge/client/app/_views/ktb-environment-view/ktb-stage-overview/ktb-stage-overview.component.ts
Outdated
Show resolved
Hide resolved
bridge/client/app/_views/ktb-service-view/ktb-deployment-list/ktb-deployment-list.component.ts
Show resolved
Hide resolved
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
renepanzar
reviewed
Jul 25, 2022
bridge/client/app/_components/ktb-approval-item/ktb-approval-item.component.ts
Show resolved
Hide resolved
bridge/client/app/_views/ktb-environment-view/ktb-environment-view.component.ts
Show resolved
Hide resolved
bridge/client/app/_views/ktb-environment-view/ktb-environment-view.component.ts
Show resolved
Hide resolved
bridge/client/app/_views/ktb-environment-view/ktb-environment-view.component.html
Outdated
Show resolved
Hide resolved
bridge/client/app/_views/ktb-environment-view/ktb-environment-view.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
heinzburgstaller
approved these changes
Jul 26, 2022
renepanzar
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks much cleaner now 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5098
Additional changes
ktb-stage-details
andktb-stage-overview
are now dump components. I replacedrouter.navigate
withlocation.go
. It caused the environment view to be re-rendered (constructor and onInit, etc. was executed again) and that caused another API call for the project.uniform-integration.spec
Signed-off-by: Klaus Strießnig k.striessnig@gmail.com