Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

refactor(bridge): Remove global project polling and remove project dependency in integrations view #8412

Merged
merged 10 commits into from Jul 27, 2022

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Jul 13, 2022

Closes #5098

Additional changes

  • ktb-stage-details and ktb-stage-overview are now dump components. I replaced router.navigate with location.go. It caused the environment view to be re-rendered (constructor and onInit, etc. was executed again) and that caused another API call for the project.
  • Fixed a flaky UI test in uniform-integration.spec
  • Fixed tsconfig for jest

Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

…pendency in integrations view

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #8412 (5bc6b03) into master (4373f21) will increase coverage by 0.43%.
The diff coverage is 96.49%.

@@            Coverage Diff             @@
##           master    #8412      +/-   ##
==========================================
+ Coverage   66.44%   66.88%   +0.43%     
==========================================
  Files         612      613       +1     
  Lines       31915    31972      +57     
  Branches     1677     1683       +6     
==========================================
+ Hits        21207    21384     +177     
+ Misses       9415     9301     -114     
+ Partials     1293     1287       -6     
Impacted Files Coverage Δ
...criptions/ktb-uniform-subscriptions.component.html 100.00% <ø> (ø)
...vironment-view/ktb-environment-view.component.html 100.00% <ø> (ø)
...ktb-stage-details/ktb-stage-details.component.html 100.00% <ø> (ø)
...trigger-sequence/ktb-trigger-sequence.component.ts 75.36% <ø> (-0.13%) ⬇️
...s/ktb-sequence-view/ktb-sequence-view.component.ts 74.89% <0.00%> (ø)
...s/ktb-service-view/ktb-service-view.component.html 100.00% <ø> (ø)
...ion/ktb-modify-uniform-subscription.component.html 100.00% <ø> (ø)
...dge/shared/fixtures/service-state-response.mock.ts 100.00% <ø> (ø)
...b-deployment-list/ktb-deployment-list.component.ts 29.72% <57.14%> (-24.99%) ⬇️
...s/ktb-approval-item/ktb-approval-item.component.ts 86.66% <100.00%> (+0.95%) ⬆️
... and 37 more
Flag Coverage Δ
bridge-server 73.77% <ø> (ø)
bridge2 80.37% <96.49%> (+1.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@Kirdock Kirdock marked this pull request as ready for review July 13, 2022 14:07
Signed-off-by: Klaus Striessnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@renepanzar renepanzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks much cleaner now 👍

@Kirdock Kirdock merged commit c4845c9 into master Jul 27, 2022
@Kirdock Kirdock deleted the refactor/5098/remove-global-project-polling branch July 27, 2022 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove global project polling from uniform screen
3 participants