-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(operator): refactor keptntaskcontroller to use builder interface (
#1450) Signed-off-by: realanna <anna.reale@dynatrace.com>
- Loading branch information
Showing
10 changed files
with
595 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
operator/controllers/lifecycle/keptntask/container_builder.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
package keptntask | ||
|
||
import ( | ||
"reflect" | ||
|
||
"github.com/go-logr/logr" | ||
klcv1alpha3 "github.com/keptn/lifecycle-toolkit/operator/apis/lifecycle/v1alpha3" | ||
"golang.org/x/net/context" | ||
corev1 "k8s.io/api/core/v1" | ||
"k8s.io/client-go/tools/record" | ||
ctrl "sigs.k8s.io/controller-runtime" | ||
"sigs.k8s.io/controller-runtime/pkg/client" | ||
) | ||
|
||
// IContainerBuilder is the interface that describes the operations needed to help build job specs of a task | ||
type IContainerBuilder interface { | ||
// CreateContainerWithVolumes returns a job container and volumes based on the task definition spec | ||
CreateContainerWithVolumes(ctx context.Context) (*corev1.Container, []corev1.Volume, error) | ||
} | ||
|
||
// BuilderOptions contains everything needed to build the current job | ||
type BuilderOptions struct { | ||
client.Client | ||
recorder record.EventRecorder | ||
req ctrl.Request | ||
Log logr.Logger | ||
task *klcv1alpha3.KeptnTask | ||
taskDef *klcv1alpha3.KeptnTaskDefinition | ||
} | ||
|
||
func getContainerBuilder(options BuilderOptions) IContainerBuilder { | ||
if isJSSpecDefined(&options.taskDef.Spec) { | ||
builder := newJSBuilder(options) | ||
return &builder | ||
} | ||
return nil | ||
} | ||
|
||
func specExists(definition *klcv1alpha3.KeptnTaskDefinition) bool { | ||
//TODO when adding new builders add more logic here | ||
return isJSSpecDefined(&definition.Spec) | ||
} | ||
|
||
func isJSSpecDefined(spec *klcv1alpha3.KeptnTaskDefinitionSpec) bool { | ||
return !reflect.DeepEqual(spec.Function, klcv1alpha3.FunctionSpec{}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.