Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed failure branch #1175

Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix: removed failure branch #1175

merged 2 commits into from
Apr 4, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Apr 3, 2023

closes #638

Signed-off-by: realanna <anna.reale@dynatrace.com>
@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit ddde421
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642acc2da623190008ee14c8
😎 Deploy Preview https://deploy-preview-1175--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1175 (219e3a4) into main (b32d753) will increase coverage by 2.23%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   56.84%   59.08%   +2.23%     
==========================================
  Files         100      128      +28     
  Lines        8977    10035    +1058     
==========================================
+ Hits         5103     5929     +826     
- Misses       3694     3889     +195     
- Partials      180      217      +37     
Impacted Files Coverage Δ
scheduler/pkg/klcpermit/permit.go 0.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.75% <ø> (ø)
lifecycle-operator 78.48% <ø> (?)
metrics-operator 77.57% <ø> (?)
scheduler 21.75% <0.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

bacherfl
bacherfl previously approved these changes Apr 3, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna requested a review from bacherfl April 3, 2023 13:55
@RealAnna RealAnna merged commit 66df012 into main Apr 4, 2023
@RealAnna RealAnna deleted the fix/remove_pod_eviction branch April 4, 2023 05:47
@keptn-bot keptn-bot mentioned this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour in keptn-scheduler
3 participants