Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hash as revision instead of generation number #1243

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix: use hash as revision instead of generation number #1243

merged 1 commit into from
Apr 18, 2023

Conversation

odubajDT
Copy link
Contributor

Fixes: #955

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit d951a6a
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/643e661bef6a550008b4549b
😎 Deploy Preview https://deploy-preview-1243--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1243 (6a41bba) into main (c9b1a42) will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   58.94%   58.92%   -0.02%     
==========================================
  Files         128      128              
  Lines       10040    10045       +5     
==========================================
+ Hits         5918     5919       +1     
- Misses       3902     3906       +4     
  Partials      220      220              
Impacted Files Coverage Δ
...rator/controllers/lifecycle/keptnapp/controller.go 63.79% <0.00%> (ø)
operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <100.00%> (ø)
operator/apis/lifecycle/v1alpha3/keptnapp_types.go 93.33% <100.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.06% <0.00%> (-0.87%) ⬇️
lifecycle-operator 78.26% <77.77%> (+0.01%) ⬆️
metrics-operator 77.57% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@odubajDT odubajDT marked this pull request as ready for review April 18, 2023 11:17
@odubajDT odubajDT merged commit 2ad5d81 into keptn:main Apr 18, 2023
@keptn-bot keptn-bot mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Revision of KeptnAppVersion is bumped on every new version
3 participants