feat(operator): trim KeptnAppVersion name that exceed max limit #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 61.57% 61.62% +0.04%
==========================================
Files 143 143
Lines 10697 10700 +3
==========================================
+ Hits 6587 6594 +7
+ Misses 3849 3846 -3
+ Partials 261 260 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
reviewed
Apr 28, 2023
bacherfl
reviewed
Apr 28, 2023
operator/controllers/lifecycle/keptnworkloadinstance/controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
changed the title
bacherfl
reviewed
May 2, 2023
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
|
thanks for making the adaptations @rakshitgondwal! the only thing left is to fix the linting issues, then we're ready to get this merged :) |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
approved these changes
May 4, 2023
bacherfl
approved these changes
May 5, 2023
Merged
|
Thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245
Changes made-
KeptnAppVersion.ObjectMeta.Nameif it exceeds the maximum length.