Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove code duplication #1372

Merged
merged 2 commits into from
May 4, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented May 4, 2023

No description provided.

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat thisthat requested a review from a team as a code owner May 4, 2023 12:03
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 5cdc635
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64539f256d9b010008fe41cf
😎 Deploy Preview https://deploy-preview-1372--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1372 (3d18b0d) into main (4398e96) will increase coverage by 0.32%.
The diff coverage is 91.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
+ Coverage   61.25%   61.58%   +0.32%     
==========================================
  Files         138      143       +5     
  Lines       10483    10695     +212     
==========================================
+ Hits         6421     6586     +165     
- Misses       3807     3848      +41     
- Partials      255      261       +6     
Impacted Files Coverage Δ
operator/controllers/common/helperfunctions.go 98.64% <91.66%> (+1.28%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (+4.26%) ⬆️
component-tests 59.22% <ø> (-0.65%) ⬇️
lifecycle-operator 82.49% <91.66%> (+0.01%) ⬆️
metrics-operator 77.90% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat merged commit da66c80 into keptn:main May 4, 2023
@thisthat thisthat deleted the chore/refactor-helper-function branch May 4, 2023 13:32
@keptn-bot keptn-bot mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants