-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: content for KeptnTaskDefinition ref and tasks guide #1392
Conversation
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publish comments
…it into 0509-taskref Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com
https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
apiVersion: lifecycle.keptn.sh/v1alpha2 kind: KeptnTaskDefinition metadata: name: scheduled-deployment spec: function: configMapRef: name: scheduled-deployment-cm-1 --- apiVersion: v1 kind: ConfigMap metadata: name: scheduled-deployment-1 data: code: | let text = Deno.env.get("DATA"); let data; if (text != "") { data = JSON.parse(text); } let targetDate = new Date(data.targetDate) let dateTime = new Date(); if(targetDate < dateTime) { console.log("Date has passed - ok"); Deno.exit(0); } else { console.log("It's too early - failing"); Deno.exit(1); } console.log(targetDate); Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
KeptnTaskDefinition
ref pageKeptnTaskDefinition
ref pageKeptnTaskDefinition
ref page also has some info about parameters and secrets. I think all the "secrets" information needs to be pulled into its own page in the "Implementing..." sectionThis PR supercedes , which supercededhttps://github.com//pull/1194, which superceded #1083, which also attempted to move the autogenerated files from the crd-ref directory to api-ref.
Satisfies #1078