Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention Prometheus in intro #1405

Merged
merged 2 commits into from
May 12, 2023
Merged

docs: mention Prometheus in intro #1405

merged 2 commits into from
May 12, 2023

Conversation

StackScribe
Copy link
Contributor

@agardnerIT commented:

Nitpicking but: Datadog, Dynatrace, Lightstep, Honeycomb, Splunk

  1. missing Prometheus
  2. it should be alphabetical OR we are subtly suggesting that datadog is better than DT.
  3. (My opinion) but we shouldn’t give free promotion. If the vendors want their name listed here, they should write a provider. By giving this list, we’re putting Honeycomb on the same footing at DT.

This PR:

  • Adds Prometheus to the list of data providers and arranges them in the order they were implemented for KLT
  • Replaced the names of other data providers with "and others"
  • Tweaked the prose a bit for better flow

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe requested review from a team as code owners May 12, 2023 04:01
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@netlify
Copy link

netlify bot commented May 12, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 807bf60
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/645dba072055f5000810cfd6
😎 Deploy Preview https://deploy-preview-1405--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@StackScribe
Copy link
Contributor Author

The build error is about the link to the HPA docs. The link works fine -- I think markdownlint has a bit of trouble to xrefs to subsections of a page

@thisthat thisthat merged commit 2c51231 into keptn:main May 12, 2023
@keptn-bot keptn-bot mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants