Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add content to implementing/otel page #1492

Merged
merged 14 commits into from
Jun 21, 2023
Merged

Conversation

StackScribe
Copy link
Contributor

This PR:

  • Copies information from getting-started/observability to the implementing/otel.md file so that the main docs have all substantive information that is in the getting-started guide
  • Adds info about prerequisites and configuration that were in the README file
  • Remove information from the aforementioned README file and replace it with a link to this page
  • Rewrite the info about "Preparing your cluster" to have only vague information about the need for the otel-collector, Grafana, and Jaeger and add a link to this page

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label May 30, 2023
@StackScribe StackScribe requested a review from a team as a code owner May 30, 2023 13:38
@StackScribe StackScribe self-assigned this May 30, 2023
@StackScribe StackScribe requested a review from a team as a code owner May 30, 2023 13:38
@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c7253f2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6475fc5512c65f0008f6f481
😎 Deploy Preview https://deploy-preview-1492--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/otel.md Show resolved Hide resolved
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 4629da6
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6476ba9b45d91a0008cb65f3
😎 Deploy Preview https://deploy-preview-1492--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

StackScribe and others added 8 commits May 30, 2023 18:22
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
thisthat
thisthat previously approved these changes Jun 20, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thisthat thisthat merged commit 452c3a9 into keptn:main Jun 21, 2023
17 checks passed
@keptn-bot keptn-bot mentioned this pull request Jun 21, 2023
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants