feat: add validating webhook for KeptnTaskDefinition #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
geoffrey1330
force-pushed
the
feat/1486/validating_webhook
branch
from
d6a4800
to
2af1475
Compare
github-actions
bot
added
documentation
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
github-actions
bot
removed
documentation
…ffrey1330/lifecycle-toolkit into feat/1486/validating_webhook Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
rakshitgondwal
requested changes
Jun 2, 2023
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
…r container spec but not both Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
rakshitgondwal
requested changes
Jun 4, 2023
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
bacherfl
reviewed
Jun 5, 2023
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
RealAnna
reviewed
Jun 5, 2023
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
RealAnna
reviewed
Jun 5, 2023
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
bacherfl
reviewed
Jun 6, 2023
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
…est.go Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
…) methods Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
approved these changes
Jun 6, 2023
odubajDT
approved these changes
Jun 7, 2023
|
@rakshitgondwal @geoffrey1330 awesome job! Thank you very much for contribution :) |
Merged
Closed
3 tasks
|
Kudos to @geoffrey1330! |
Thanks for the support @rakshitgondwal |
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 22, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com> Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1486 Added webhook validation for TaskDefinitions in the lifecycle operator