Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document container-runtime and python-runtime runners #1579

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

StackScribe
Copy link
Contributor

Document the container-runtime feature as implemented in #1493.
This replaces #1521 , which has lots of comments and discussions but got corrupted.
This satisfies #1489.

This PR includes:

  • Updates to the KeptnTaskDefinition page to show the different runners in Synopsis, Field definitions, and examples
  • Updates to the KeptnApp page
  • Update the implementing/tasks page with information
  • Update the "Managing release lifecycle" Getting started guide to say that tasks can be defined with different runners and link to the implementing/tasks page for more information
  • Fix a typo in the implementing/integrate page

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Jun 19, 2023
@StackScribe StackScribe self-assigned this Jun 19, 2023
@StackScribe StackScribe requested review from a team as code owners June 19, 2023 11:51
@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 84aed18
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/649176f89f721700084fdd8a
😎 Deploy Preview https://deploy-preview-1579--keptn-lifecycle-toolkit.netlify.app/docs/yaml-crd-ref/taskdefinition
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thisthat
thisthat previously approved these changes Jun 19, 2023
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

odubajDT
odubajDT previously approved these changes Jun 20, 2023
StackScribe and others added 2 commits June 20, 2023 10:50
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
thisthat
thisthat previously approved these changes Jun 20, 2023
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 3834b70 into keptn:main Jun 20, 2023
@keptn-bot keptn-bot mentioned this pull request Jun 20, 2023
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jun 20, 2023
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants