-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document container-runtime and python-runtime runners #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thisthat
reviewed
Jun 19, 2023
thisthat
previously approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
odubajDT
reviewed
Jun 19, 2023
RealAnna
reviewed
Jun 19, 2023
RealAnna
reviewed
Jun 19, 2023
RealAnna
reviewed
Jun 19, 2023
thisthat
reviewed
Jun 20, 2023
thisthat
reviewed
Jun 20, 2023
RealAnna
reviewed
Jun 20, 2023
RealAnna
reviewed
Jun 20, 2023
StackScribe
commented
Jun 20, 2023
thisthat
force-pushed
the
0619-new-container-runtime
branch
from
June 20, 2023 08:37
475a9b1
to
09ca772
Compare
odubajDT
previously approved these changes
Jun 20, 2023
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com> Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
thisthat
force-pushed
the
0619-new-container-runtime
branch
from
June 20, 2023 08:50
a9ad627
to
d5507dc
Compare
thisthat
previously approved these changes
Jun 20, 2023
RealAnna
reviewed
Jun 20, 2023
RealAnna
reviewed
Jun 20, 2023
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
RealAnna
approved these changes
Jun 20, 2023
odubajDT
approved these changes
Jun 20, 2023
Merged
Nitishupkr
pushed a commit
to Nitishupkr/lifecycle-toolkit
that referenced
this pull request
Jun 20, 2023
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com> Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
StackScribe
added a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 22, 2023
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com> Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the container-runtime feature as implemented in #1493.
This replaces #1521 , which has lots of comments and discussions but got corrupted.
This satisfies #1489.
This PR includes:
KeptnTaskDefinition
page to show the different runners in Synopsis, Field definitions, and examplesKeptnApp
page