Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collectors to Metrics Integration Tests #2699

Closed
1 task
Tracked by #1881
RealAnna opened this issue Dec 19, 2023 · 3 comments · Fixed by #2765
Closed
1 task
Tracked by #1881

Add collectors to Metrics Integration Tests #2699

RealAnna opened this issue Dec 19, 2023 · 3 comments · Fixed by #2765
Assignees
@rizul2108
Labels
good first issue Good for newcomers tests

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Dec 19, 2023 •
edited
Loading

Given this generic example on how to add a collector to kuttl tests #1834, we should add collectors in each metrics integration test that:

  • collect logs of metrics-operator
  • run a kubectl describe for application pod, HPA, KeptnMetric and KeptnMetricsProvider (if they exist in the test)

DoD

  • manually verify that when the test fails, the logs and describes are visible in the shell
@RealAnna RealAnna mentioned this issue Dec 19, 2023
Open
5 tasks
@RealAnna RealAnna changed the title metrics (M, C) Add collectors to metrics integration tests Dec 19, 2023
@RealAnna RealAnna changed the title Add collectors to metrics integration tests Add collectors to Metrics Integration Tests Dec 19, 2023
@RealAnna RealAnna added good first issue Good for newcomers tests labels Dec 19, 2023
@RealAnna RealAnna mentioned this issue Dec 19, 2023
Open
1 task
@mowies mowies added the status: ready-for-refinement Issue is relevant for the next backlog refinment label Dec 19, 2023
@mowies mowies added this to the 0.12 milestone Dec 19, 2023
@odubajDT odubajDT removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Dec 20, 2023
@rizul2108
Copy link
Contributor

I want to work on this issue. Can you please assign this issue to me? @mowies

@mowies
Copy link
Member

mowies commented Dec 27, 2023

Great! I assigned it to you :)

@rizul2108 rizul2108 mentioned this issue Jan 7, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rizul2108 rizul2108

Labels
good first issue Good for newcomers tests
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve metrics integration tests by adding kuttl log collectors
4 participants
@mowies @RealAnna @odubajDT @rizul2108