feat: add cert-manager logic #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealAnna
requested review from
thisthat,
thschue and
bacherfl
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 49.83% 49.87% +0.03%
==========================================
Files 60 60
Lines 5528 5528
==========================================
+ Hits 2755 2757 +2
+ Misses 2664 2663 -1
+ Partials 109 108 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
changed the base branch from
main
to
feat/introduce_certmanager_operator
RealAnna
force-pushed
the
feat/introduce_certmanager_operator
branch
from
c7a0e9c
to
2dae13f
Compare
RealAnna
force-pushed
the
feat/certmanager_operator_logic
branch
from
3f9a0a2
to
e355d36
Compare
mowies
reviewed
Dec 15, 2022
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Dec 16, 2022
odubajDT
reviewed
Dec 16, 2022
cert-manager/controllers/keptnwebhookcontroller/certificate_secret.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Dec 16, 2022
odubajDT
reviewed
Dec 16, 2022
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Dec 16, 2022
cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Dec 16, 2022
RealAnna
force-pushed
the
feat/certmanager_operator_logic
branch
from
e355d36
to
d9fccd3
Compare
bacherfl
reviewed
Dec 19, 2022
mowies
reviewed
Dec 19, 2022
RealAnna
force-pushed
the
feat/certmanager_operator_logic
branch
from
7d43bab
to
f5c4e99
Compare
RealAnna
force-pushed
the
feat/introduce_certmanager_operator
branch
from
736688e
to
20fb545
Compare
odubajDT
reviewed
Dec 21, 2022
odubajDT
reviewed
Dec 21, 2022
odubajDT
reviewed
Dec 21, 2022
odubajDT
reviewed
Dec 21, 2022
odubajDT
reviewed
Dec 21, 2022
odubajDT
reviewed
Dec 21, 2022
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Dec 21, 2022
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Dec 21, 2022
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Dec 21, 2022
RealAnna
force-pushed
the
feat/certmanager_operator_logic
branch
from
36dda88
to
bd8749d
Compare
RealAnna
force-pushed
the
feat/certmanager_operator_logic
branch
from
f76be02
to
7742580
Compare
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/certificate_secret.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jan 10, 2023
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/certificate_secret.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/certificate_secret.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Show resolved
Hide resolved
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jan 10, 2023
klt-cert-manager/controllers/keptnwebhookcontroller/webhook_cert_controller_test.go
Show resolved
Hide resolved
RealAnna
force-pushed
the
feat/certmanager_operator_logic
branch
2 times, most recently
from
705663c
to
4292f3a
Compare
Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added base for cert-manager Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com> rename Signed-off-by: RealAnna <anna.reale@dynatrace.com> rename Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: peer review Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Update klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Update klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Update klt-cert-manager/controllers/keptnwebhookcontroller/keptnwebhookcertificate_controller.go Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> rename Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added logic for cert handling Signed-off-by: RealAnna <anna.reale@dynatrace.com> removed old label Signed-off-by: RealAnna <anna.reale@dynatrace.com> fix according to reviews Signed-off-by: RealAnna <anna.reale@dynatrace.com> fix according to reviews Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: fix certmanager logic Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added secrets for conv webhook Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: tests Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: cleaned up Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added crds config Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: peer review, renamed things Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added logic for cert handling Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: removedatogenerated TODO Signed-off-by: RealAnna <anna.reale@dynatrace.com> feat: added logic for cert handling Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com> addressed reviews Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com> added to CI build Signed-off-by: RealAnna <anna.reale@dynatrace.com> added to CI build Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com> review Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> review Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> review Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
feat/certmanager_operator_logic
branch
from
4292f3a
to
16e4b47
Compare
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Jan 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds logic to generate certificate fo the lifecycle toolkit operator, the whiring and changes to the operator will be in a follow up pr.
main controller logic:
the whole kubeobject folder uses code from dynatrace/operator
the code in keptnwebhookcontroller is an adaptation of dynatrace/operator/certcontroller