Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken link to examples folder in README.md #671

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

rakshitgondwal
Copy link
Member

Fixes #670

Updated the link to the examples folder in README.md at line 100 to ./examples/sample-app/

@rakshitgondwal rakshitgondwal changed the title Fix: Broken link to examples folder in README.md fix: Broken link to examples folder in README.md Jan 20, 2023
@thisthat thisthat changed the title fix: Broken link to examples folder in README.md fix: broken link to examples folder in README.md Jan 20, 2023
@thisthat
Copy link
Member

Hey @rakshitgondwal, thank you for your contribution :)
Could you please sign your commit? You can do that using this command: git rebase HEAD~1 --signoff

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #671 (d22dd11) into main (a3b0f7b) will decrease coverage by 0.80%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   56.36%   55.56%   -0.80%     
==========================================
  Files          82       74       -8     
  Lines        6683     6239     -444     
==========================================
- Hits         3767     3467     -300     
+ Misses       2756     2650     -106     
+ Partials      160      122      -38     
Impacted Files Coverage Δ
klt-cert-manager/kubeutils/query.go
klt-cert-manager/kubeutils/certificates.go
...llers/keptnwebhookcontroller/certificate_secret.go
klt-cert-manager/eventfilter/eventfilter.go
...okcontroller/keptnwebhookcertificate_controller.go
...rs/keptnwebhookcontroller/webhook_configuration.go
klt-cert-manager/kubeutils/secret.go
...anager/controllers/keptnwebhookcontroller/certs.go
Flag Coverage Δ
component-tests 52.84% <ø> (ø)
keptn-cert-manager ?
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thisthat thisthat merged commit 4ff944b into keptn:main Jan 27, 2023
@keptn-bot keptn-bot mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken link to examples folder in README.md
3 participants