fix(operator): prevent re-execution of workload tasks that have been cancelled in a previous KLT version #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cancelled in a previous KLT version Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
=======================================
Coverage 57.33% 57.33%
=======================================
Files 88 88
Lines 7001 7004 +3
=======================================
+ Hits 4014 4016 +2
- Misses 2821 2822 +1
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Jan 30, 2023
thisthat
approved these changes
Jan 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #680
This PR prevents tasks of WorkloadInstances being attempted to be reconciled if they are in the
Cancelledstate (which had been replaced withDeprecatedrecently).Signed-off-by: Florian Bacher florian.bacher@dynatrace.com