Convert ddim #743
Merged
Convert ddim #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
freedomtan
commented
Aug 17, 2023
freedomtan
commented
- colab notebook
- diff f98790b
- convert keras/tf.keras to keras_core
- replace most of tf ops except tf.image, tf.data, and tf.GrapdientTap
- fix ops.concat out of range issue
1. convert keras/tf.keras to keras_core 2. replace most of tf ops except tf.image, tf.data, and tf.GrapdientTap 3. fix ops.concat out of range issue
fchollet
reviewed
Aug 17, 2023
| @@ -69,7 +69,8 @@ def build(self, input_shape): | |||
| if axis != concat_axis and axis_value == 1: | |||
| del reduced_inputs_shapes[i][axis] | |||
|
|
|||
| del reduced_inputs_shapes[i][self.axis] | |||
| if len(reduced_inputs_shapes[i]) > self.axis: | |||
There was a problem hiding this comment.
In the example, in Inception V3, some axes were squeezed out, and thus, there were error messages showing out-of-range while accessing the reduced_inputs_shapes[i][self.axis]. Alternatives I could think of:
- Don’t squeeze
- When squeezing, also decrement
self.axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.