-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Nightly package for keras-cv
#2139
Conversation
/gcbrun |
@sampathweb Thank you for the PR! LGTM but I would wait till our tests are passing with the new keras 3 compat changes before releasing nightlies. |
Sure. We can wait to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me thanks! just one comment
@@ -49,14 +50,34 @@ def ignore_files(_, filenames): | |||
return [f for f in filenames if "test" in f] | |||
|
|||
|
|||
def build(): | |||
def export_version_string(version, is_nightly=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like our version string in __init__.py
is the current release version. Maybe we should update that to 0.7.0
so it is pointing to the next major version we will release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I will merge this PR now. Plan to fix the tests before nightly runs tonight. |
* Add Nightly package * update version
Adds Nightly package for
keras-cv