Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Nightly package for keras-cv #2139

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

sampathweb
Copy link
Collaborator

Adds Nightly package for keras-cv

@sampathweb sampathweb marked this pull request as ready for review November 10, 2023 03:50
@divyashreepathihalli
Copy link
Collaborator

/gcbrun

@divyashreepathihalli
Copy link
Collaborator

@sampathweb Thank you for the PR! LGTM but I would wait till our tests are passing with the new keras 3 compat changes before releasing nightlies.

@sampathweb
Copy link
Collaborator Author

@sampathweb Thank you for the PR! LGTM but I would wait till our tests are passing with the new keras 3 compat changes before releasing nightlies.

Sure. We can wait to merge.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me thanks! just one comment

@@ -49,14 +50,34 @@ def ignore_files(_, filenames):
return [f for f in filenames if "test" in f]


def build():
def export_version_string(version, is_nightly=False):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like our version string in __init__.py is the current release version. Maybe we should update that to 0.7.0 so it is pointing to the next major version we will release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sampathweb
Copy link
Collaborator Author

I will merge this PR now. Plan to fix the tests before nightly runs tonight.

@sampathweb sampathweb merged commit e52523a into keras-team:master Nov 10, 2023
6 of 9 checks passed
@sampathweb sampathweb deleted the nightly-cv branch November 10, 2023 19:42
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
* Add Nightly package

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants