Migrate channel_shuffle to use BaseImageAugmentationLayer #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeWood
reviewed
Mar 28, 2022
LukeWood
reviewed
Mar 28, 2022
| width = tf.shape(images)[2] | ||
| num_channels = images.shape[3] | ||
| def augment_image(self, image, transformation=None): | ||
| height = tf.shape(image)[0] |
There was a problem hiding this comment.
reduce this to a single tf.shape call.
height, width, num_channels = tf.shape(image)
or
shape = tf.shape(image)
height, width, num_channels = shape[0], shape[1], shape[2]
|
Thanks for the great PR. Few minor comments. @quantumalaviya |
LukeWood
reviewed
Mar 28, 2022
LukeWood
approved these changes
Apr 1, 2022
|
Thanks @quantumalaviya |
Closed
ianstenbit
pushed a commit
to ianstenbit/keras-cv
that referenced
this pull request
Aug 6, 2022
…#218) * Migrate channel_shuffle to use BaseImageAugmentationLayer * Migrate channel_shuffle to use BaseImageAugmentationLayer * width and height use one tf.shape call
adhadse
pushed a commit
to adhadse/keras-cv
that referenced
this pull request
Sep 17, 2022
…#218) * Migrate channel_shuffle to use BaseImageAugmentationLayer * Migrate channel_shuffle to use BaseImageAugmentationLayer * width and height use one tf.shape call
freedomtan
pushed a commit
to freedomtan/keras-cv
that referenced
this pull request
Jul 20, 2023
* Add scatter_update and block_update * Add docstring * remove explicit conversion * Fix docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #187