Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue(keras-team#2195): Improve readability and comprehensibility of Stable Diffusion source #2197

Conversation

y-vectorfield
Copy link
Contributor

@y-vectorfield y-vectorfield commented Nov 28, 2023

What does this PR do?

I added the casting method to Stable Diffusion source as y-vectorfield-fj(my previous account name).
However, this method is implemented abruptly and unnaturally.
Hence, I modified the source and added comments to improve readability and comprehensibility.

Who can review?

@ianstenbit
@sampathweb

@sampathweb
Copy link
Collaborator

@y-vectorfield - This PR only adds a comment - # Keras backend array need to cast explicitly. It may not be required. If it was adding any doc strings for the user, it might be useful. So for now, we could close this PR?

@sampathweb sampathweb self-requested a review December 9, 2023 01:45
@sampathweb sampathweb self-requested a review December 9, 2023 01:46
@y-vectorfield
Copy link
Contributor Author

y-vectorfield commented Dec 11, 2023

@y-vectorfield - This PR only adds a comment - # Keras backend array need to cast explicitly. It may not be required. If it was adding any doc strings for the user, it might be useful. So for now, we could close this PR?

@sampathweb, thank you very much for your comments and review.
I think this modification is necessary for the improvement of Keras's CV.
If we add the state-of-the-art DL models, we will refer to the previous models of this.
Hence, I thought it was necessary to improve readability and comprehensibility.
If there is no problem, please merge my modification.

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Dec 11, 2023
@divyashreepathihalli divyashreepathihalli merged commit e4fbbe0 into keras-team:master Dec 11, 2023
6 of 9 checks passed
@divyashreepathihalli
Copy link
Collaborator

Merged, Thank you!

@y-vectorfield
Copy link
Contributor Author

@divyashreepathihalli, thank you very much!

yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Runs Tests on GPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants