-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update random_crop_and_zoom.py #2294
Update random_crop_and_zoom.py #2294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for identifying this!
let us update the file name to random_crop_and_resize_demo.py
@@ -12,7 +12,7 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
"""random_resized_crop_demo.py.py shows how to use the RandomResizedCrop | |||
"""random_crop_and_resize.py shows how to use the RandomCropAndResize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets rephrase it as " This demo example shows how to use RandomResizedCrop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RandomResizedCrop is split into multiple API's and it should be RandomCropAndResize as per the details here in the document.
I have rephrased it as per your suggestion. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - let us update the file name to random_crop_and_resize_demo.py
And run shell/format.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
LGTM! Thank you! Merged! |
* update the layer * update build * fix text encoder * update clip_model * Update random_crop_and_zoom.py (#2294) * Update random_crop_and_zoom.py * Update description * rename file * fix text features dimension * update clip_model * update clip_model --------- Co-authored-by: Divyashree Sreepathihalli <divyashreepathihalli> Co-authored-by: Sachin Prasad <sachinprasad@google.com>
* Update random_crop_and_zoom.py * Update description * rename file
* Move keras-cv markdown files to toplevel (#2291) Keras, KerasNLP and KerasTuner all store things liek the CONTRIBUTING.md in the toplevel of the repo. We should do the same here. * Add `version()` API to unify with Keras and KerasNLP (#2199) * Unify `version` API with keras and keras_nlp * Formatting * Update to keep `version` parity with KerasNLP, support nightly version string * Update version_utils.py * Update version_utils.py * Update random_crop_and_zoom.py (#2294) * Update random_crop_and_zoom.py * Update description * rename file * bug fix (#2303) * Add BASNet Segmentation Model (#2006) (#2271) * BASNet model initial code structure * adding test and initial preset details * adding comments * cleaning and formatting code * keras 3 support added * disabling preset test for BASNet * Fix image.shape type (#2305) Fixed image.shape issue for tensorflow backend * Create workflow for auto assignment of issues and for stale issues (#2313) * Create auto-assignment.yaml * Create auto-assignment.js * Create stale-issue-pr.yaml * Rename auto-assignment.yaml to auto-assignment.yml * Rename stale-issue-pr.yaml to stale-issue-pr.yml * Fix format and Update Vectorized Base (#2323) * Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX (#2322) * Reduce memory consumption for BasNet tests (#2325) --------- Co-authored-by: Matt Watson <1389937+mattdangerw@users.noreply.github.com> Co-authored-by: Gabriel Rasskin <43894452+grasskin@users.noreply.github.com> Co-authored-by: Sachin Prasad <sachinprasad@google.com> Co-authored-by: Haifeng Jin <5476582+haifeng-jin@users.noreply.github.com> Co-authored-by: Hamid Ali <hamidriasat@gmail.com> Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com>
* Update random_crop_and_zoom.py * Update description * rename file
Update RandomResizedCrop to RandomCropAndResize