Fixed ROI Pooling Output Shape to Consider Multiple ROIs (#2350) #2360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keras ROI Pooling was not including multiple ROIs in the output. Instead, only the first ROI was included. Documentation for underlying function that created per-feature-map ROI Pools was similarly incorrect. Thus, I also corrected the documentation for
_pool_single_sample
to match the expectations provided inROIPooler.call
.Corresponding test cases were updated to reflect the update and a new test was added to test this specific situation.
Fixes #2350.
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.