Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ROI Pooling Output Shape to Consider Multiple ROIs (#2350) #2360

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

VarunS1997
Copy link
Collaborator

What does this PR do?

Keras ROI Pooling was not including multiple ROIs in the output. Instead, only the first ROI was included. Documentation for underlying function that created per-feature-map ROI Pools was similarly incorrect. Thus, I also corrected the documentation for _pool_single_sample to match the expectations provided in ROIPooler.call.

Corresponding test cases were updated to reflect the update and a new test was added to test this specific situation.

Fixes #2350.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case. (Possible indentation error #2350)
  • Did you write any new necessary tests?
  • If this adds a new model, can you run a few training steps on TPU in Colab to ensure that no XLA incompatible OP are used?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks.

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Feb 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 27, 2024
@divyashreepathihalli divyashreepathihalli merged commit 18b8d79 into master Feb 27, 2024
17 checks passed
@VarunS1997 VarunS1997 deleted the bugfix/roi-pooling-indentation branch February 27, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible indentation error
4 participants