Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat code for the kerasCV image classification guide #1720

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

sitamgithub-MSIT
Copy link
Contributor

The reason for these modifications is actually not an error but rather a section of code that was repeated twice during the guide's writing. Here is a picture of it

Screenshot (324)

This code attempts to resize the evaluation dataset for inference; however, it is duplicated twice throughout the py, md, and ipynb files. Additionally, resizing was already completed for the train dataset in the form of an augmentation layer. Consequently, not for the train dataset either.

I did not raise any issues about it because it did not result in any errors. I have just made a pull request and eliminated the recurring instances.

cc: @fchollet

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix!

@fchollet fchollet merged commit ac7f64c into keras-team:master Jan 10, 2024
4 checks passed
SuryanarayanaY pushed a commit to SuryanarayanaY/keras-io that referenced this pull request Jan 19, 2024
@sitamgithub-MSIT sitamgithub-MSIT deleted the kerascv-classification branch May 30, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants