Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an example on AdaMatch #513

Merged
merged 12 commits into from
Jun 22, 2021
Merged

Adding an example on AdaMatch #513

merged 12 commits into from
Jun 22, 2021

Conversation

sayakpaul
Copy link
Contributor

@sayakpaul sayakpaul commented Jun 19, 2021

This example introduces important concepts like semi-supervised learning and domain adaptation. At the same time, it also implements AdaMatch, which currently achieves SOTA on unsupervised domain adaptation.

Accompanying Colab Notebook is available here.

@google-cla google-cla bot added the cla: yes label Jun 19, 2021
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR -- very cool new example!

examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Show resolved Hide resolved
@sayakpaul
Copy link
Contributor Author

@fchollet I have addressed all the feedback. Let me know if I should proceed to add the generated files.

@sayakpaul sayakpaul changed the title Adding an example AdaMatch Adding an example on AdaMatch Jun 21, 2021
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I made some copyedits, please pull them first.

examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
@sayakpaul
Copy link
Contributor Author

@fchollet applied your recent suggestions. Let me know if I am good to proceed with the next steps.

examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! It looks good, please make these last changes and you can add the generated files.

examples/vision/adamatch.py Outdated Show resolved Hide resolved
examples/vision/adamatch.py Outdated Show resolved Hide resolved
@sayakpaul
Copy link
Contributor Author

@fchollet done. Ready for you to take the reigns.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the great contribution! 👍

@fchollet fchollet merged commit 4f99fc5 into keras-team:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants