Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SE-Net and SE-ResNeXt to keras.applications #15267

Closed
innat opened this issue Aug 28, 2021 · 9 comments
Closed

Add SE-Net and SE-ResNeXt to keras.applications #15267

innat opened this issue Aug 28, 2021 · 9 comments
Labels
type:feature The user is asking for a new feature.

Comments

@innat
Copy link

innat commented Aug 28, 2021

System information.

TensorFlow version (you are using): 2.5
Are you willing to contribute it (Yes/No): Yes. As much as possible.

Describe the feature and the current behavior/state.

Model like SEResNeXt( [50, 101] ) and SE-Net[154] are absent (for unknown reason to me) in keras application along with other models. So, I think, It would be a good addition to the keras core library. FYI, these models are widely used in Kaggle competition.

Will this change the current api? How?
Yes. It will change as follows

tensorflow.keras.applications.SEResNeXt50
tensorflow.keras.applications.SEResNeXt101
tensorflow.keras.applications.SENet152`

Who will benefit from this feature?
ML engineers and researcher who uses tf.keras.

Others

Others implementation: https://github.com/qubvel/classification_models

@innat innat added the type:feature The user is asking for a new feature. label Aug 28, 2021
@rchao
Copy link
Contributor

rchao commented Sep 2, 2021

Thanks for opening the issue. Can you provide a paragraph as a proposal for justifying adding this model? If you can provide some context of how widely this is used or some citation, that would be helpful.

@innat
Copy link
Author

innat commented Sep 2, 2021

@rchao Thanks for asking.
Replying to all your requests, #15267, #15268, #15269, #15270

There is nothing new additional argument for justification I could use compared to the arguments that apply for available models like inceptionv3, resent densenet etc. I'm not fully sure why you're seeking a proposal as you mentioned, so please let me know why these models are not worthy to add and need proposals (I'm seriously don't know if there is any known issue. Is it for lack of man-power or something else! If keras follows some policy here to add new models).

However, I can give some overview of how these models are widely used. For example, let's say in kaggle competition, these SENet models are used frequently used as part of the experiments, link, amazing notebooks, link, link. I can provide more where these models are used actively. Along with these models, RegNets, ResNeSt, NFNet is also worthy to add. All of these models are widely used in the Computer Vision competitions in Kaggle.

The point is, those models which are not available in keras.applications, a user needs to adopt other sources, and sometimes it's not always feasible to use those implementations and needs to support along with the new tf. keras version.

[ It looks some of the requested models were added but dunno what happened next, ResNeXt keras-team/keras#85, ResNeXt keras-team/keras#26 ]

@innat
Copy link
Author

innat commented Sep 5, 2021

@rchao
Could you please give some feedback on this?

@rchao
Copy link
Contributor

rchao commented Sep 17, 2021

@innat thanks for the information, and sorry for the delayed response here. The general criteria for adding a new application is that the model has 50 or more citations on the paper, and the requester can provide a PR for us to review. In this case, the PR should include an ImageNet checkpoint.

Can you show us the citation count or other reference demonstrating the popularity, and we'll assess to let you know whether we should proceed?

@innat
Copy link
Author

innat commented Sep 17, 2021

@rchao Thanks for the response.

For citation, I think it's not required to state the citation count for Issue #15269 as we have already ResNet 50/101. However,

  • For SENet based models such as SENet, SE-ResNet, SE-ResNeXt, could you please check the citation count here, source, I think it's about ~1900 citation.

  • For the ResNeXt model, could you please check here, source, I think it's about ~1000 citations?

Is this something you asked? Please let me know. ( And just to inform, I've created different issue regarding these models so that if PRs are welcomed, the contributor can work on specifically. )

@rchao
Copy link
Contributor

rchao commented Sep 17, 2021

Thanks @innat. Does this model have an imagenet checkpoint as well?

@innat
Copy link
Author

innat commented Sep 17, 2021

@rchao yes, (afaik) they do. Here is the third-party implementation, and here is the list of imagenet weights.

@gcunhase
Copy link

gcunhase commented Jun 3, 2022

Any update on this?

@tanzhenyu
Copy link
Contributor

I will transfer this issue to KerasCV, if there's no objection

@innat innat closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature The user is asking for a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants