Fix for a change in JAX's promotion rules for floor and ceil.
#19946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAX has an unreleased change jax-ml/jax#21441 that make it so that `int`s and `bool`s are no longer promoted to floats by `floor` and `ceil`. Our current implementation follows the Numpy promotion rule, i.e. `int`s and `bool`s are promoted to floats. Therefore: - updated unit tests, which use `jax.numpy` as the reference. - updated our JAX implementation of `floor` and `ceil` (note that `ceil` would already cast).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19946 +/- ##
=======================================
Coverage 79.06% 79.07%
=======================================
Files 499 499
Lines 46727 46730 +3
Branches 8618 8618
=======================================
+ Hits 36947 36950 +3
Misses 8045 8045
Partials 1735 1735
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
google-ml-butler
bot
added
kokoro:force-run
ready to pull
fchollet
approved these changes
Jul 1, 2024
google-ml-butler
bot
removed
awaiting review
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAX has an unreleased change jax-ml/jax#21441 that make it so that
ints andbools are no longer promoted to floats byfloorandceil.Our current implementation follows the Numpy promotion rule, i.e.
ints andbools are promoted to floats. Therefore:jax.numpyas the reference.floorandceil(note thatceilwould already cast).