Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded channels_last in efficientnet_v2 #672

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Remove hardcoded channels_last in efficientnet_v2 #672

merged 5 commits into from
Dec 19, 2023

Conversation

Inquisitive-ME
Copy link
Contributor

Replace hard-coded channels_last in efficientnet_v2 with the backend data format

fchollet
fchollet reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The code looks good. Please add a unit test.

@Inquisitive-ME
Copy link
Contributor Author

I added channels first tests to applications_test and fixed two more issues that were found from running those tests

fchollet
fchollet approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hertschuh
Copy link
Contributor

Hi @Inquisitive-ME ,

Thanks for the PR, but please reformat the code using ./shell/format.sh.

Thanks,
Fabien

@sampathweb sampathweb added ready to pull Ready to be merged into the codebase and removed ready to pull Ready to be merged into the codebase labels Nov 8, 2023
copybara-service bot pushed a commit that referenced this pull request Nov 9, 2023
@Inquisitive-ME @tensorflower-gardener
PR #672: Remove hardcoded channels_last in efficientnet_v2
eba6aee 
Imported from GitHub PR #672

Replace hard-coded channels_last in efficientnet_v2 with the backend data format
Copybara import of the project:

--
214fc39 by Richard Swanson <rswanson05@gmail.com>:

 Remove hardcoded channels_last in efficientnet_v2 and replace with backend data format

--
c52e562 by Richard Swanson <rswanson05@gmail.com>:

Add channels first testing for applications_test and cleanup testing script

--
faa997d by Richard Swanson <rswanson05@gmail.com>:

Fix failing channels first tests for efficientnet and mobilenet_v3

--
cf9f492 by Richard Swanson <rswanson05@gmail.com>:

Fix code formatting

Merging this change closes #672

FUTURE_COPYBARA_INTEGRATE_REVIEW=#672 from Inquisitive-ME:fix-efficientnet_v2-channels-first cf9f492
PiperOrigin-RevId: 580748697
@copybara-service copybara-service bot mentioned this pull request Nov 9, 2023
Open
copybara-service bot pushed a commit that referenced this pull request Nov 16, 2023
@Inquisitive-ME @tensorflower-gardener
PR #672: Remove hardcoded channels_last in efficientnet_v2
a0e548e 
Imported from GitHub PR #672

Replace hard-coded channels_last in efficientnet_v2 with the backend data format
Copybara import of the project:

--
214fc39 by Richard Swanson <rswanson05@gmail.com>:

 Remove hardcoded channels_last in efficientnet_v2 and replace with backend data format

--
c52e562 by Richard Swanson <rswanson05@gmail.com>:

Add channels first testing for applications_test and cleanup testing script

--
faa997d by Richard Swanson <rswanson05@gmail.com>:

Fix failing channels first tests for efficientnet and mobilenet_v3

--
cf9f492 by Richard Swanson <rswanson05@gmail.com>:

Fix code formatting

Merging this change closes #672

FUTURE_COPYBARA_INTEGRATE_REVIEW=#672 from Inquisitive-ME:fix-efficientnet_v2-channels-first cf9f492
PiperOrigin-RevId: 580748697
hertschuh
hertschuh requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inquisitive-ME

Sorry for the delay. This was not merged because the tests are failing. See my comments in the code.

Thanks!

tf_keras/applications/applications_test.py Outdated Show resolved Hide resolved
tf_keras/applications/applications_test.py Outdated Show resolved Hide resolved
copybara-service bot pushed a commit that referenced this pull request Dec 1, 2023
@Inquisitive-ME @tensorflower-gardener
PR #672: Remove hardcoded channels_last in efficientnet_v2
0c672ff 
Imported from GitHub PR #672

Replace hard-coded channels_last in efficientnet_v2 with the backend data format
Copybara import of the project:

--
214fc39 by Richard Swanson <rswanson05@gmail.com>:

 Remove hardcoded channels_last in efficientnet_v2 and replace with backend data format

--
c52e562 by Richard Swanson <rswanson05@gmail.com>:

Add channels first testing for applications_test and cleanup testing script

--
faa997d by Richard Swanson <rswanson05@gmail.com>:

Fix failing channels first tests for efficientnet and mobilenet_v3

--
cf9f492 by Richard Swanson <rswanson05@gmail.com>:

Fix code formatting

--
6840eb4 by Richard Swanson <rswanson05@gmail.com>:

Fix applications_test setup and teardown

Merging this change closes #672

FUTURE_COPYBARA_INTEGRATE_REVIEW=#672 from Inquisitive-ME:fix-efficientnet_v2-channels-first 6840eb4
PiperOrigin-RevId: 587025448
@copybara-service copybara-service bot mentioned this pull request Dec 1, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Dec 19, 2023
@hertschuh @tensorflower-gardener
PR #672: Remove hardcoded channels_last in efficientnet_v2
cf20a6b 
Replace hard-coded channels_last in efficientnet_v2 with the backend data format

Imported from GitHub PR tensorflow/tensorflow#672

Copybara import of the project:

  - 214fc39  Remove hardcoded channels_last in efficientnet_v2 and re... by Richard Swanson <rswanson05@gmail.com>
  - c52e562 Add channels first testing for applications_test and clea... by Richard Swanson <rswanson05@gmail.com>
  - faa997d Fix failing channels first tests for efficientnet and mob... by Richard Swanson <rswanson05@gmail.com>
  - cf9f492 Fix code formatting by Richard Swanson <rswanson05@gmail.com>
  - 6840eb4 Fix applications_test setup and teardown by Richard Swanson <rswanson05@gmail.com>
  - 3e7f605 Merge 6840eb4 into 5359b... by Inquisitive-ME <rswanson05@gmail.com>

FUTURE_COPYBARA_INTEGRATE_REVIEW=#672 from Inquisitive-ME:fix-efficientnet_v2-channels-first 6840eb4
PiperOrigin-RevId: 592035715
@copybara-service copybara-service bot mentioned this pull request Dec 19, 2023
Merged
@copybara-service copybara-service bot merged commit 3c9a51b into keras-team:master Dec 19, 2023
2 of 3 checks passed
@github-actions github-actions bot removed the ready to pull Ready to be merged into the codebase label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hertschuh hertschuh hertschuh requested changes

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Inquisitive-ME @hertschuh @fchollet @sampathweb @sachinprasadhs