bind a port with only public routes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
showing pertinent config seems more scalable than trying to fit the same bits into sentences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specifying
PUBLIC_PORT, a person may bind AuthN on two ports with two different routing tables:PORT, with all routes (public & private)PUBLIC_PORT, with only public routes.When configured this way, a public load balancer or SSL terminating proxy can easily and safely forward to the public port without concern for exposing admin endpoints to the general internet.
This two-port setup is designed to be backwards compatible. There's a chance it could be revisited and improved in a 2.x release some day.
Fixes #33