Simplify code maintenance #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ferraz-oliveira
force-pushed
the
feature/less-code-via-cache-and-restore
branch
from
d05d228
to
ea62007
Compare
|
If you write echo "$_KERL_TARGET_VAR=\"$_KERL_CFG_VAR\""just before the last |
And to think ShellCheck tried to teach me this so many times :)
I specifically tested this mechanism for KERL_DEPLOY_SSH_OPTIONS with
```
f() {
echo 1: $1
echo 2: $2
}
f $KERL_DEPLOY_SSH_OPTIONS
```
by using
```
KERL_DEPLOY_SSH_OPTIONS="opt1 opt2" ./kerl
```
and got
```
1: opt1
2: opt2
```
| @@ -281,6 +261,9 @@ KERL_BUILD_DOCS= | |||
| KERL_DOC_TARGETS=chunks | |||
| KERL_BUILD_BACKEND= | |||
| KERL_RELEASE_TARGET= | |||
| " | |||
| act_on_kerl_cfgs "$_KERL_CFGS" "cache" | |||
There was a problem hiding this comment.
Called it here to have the _KERL_CFGS variable defined, but it does (similar to) what's above, from lines 227-268.
jadeallenx
approved these changes
Oct 24, 2023
paulo-ferraz-oliveira
deleted the
feature/less-code-via-cache-and-restore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eases maintenance by auto-assigning variables declared as strings in
_KERL_CFGS.Closes #194.