Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust circuit-breaker for #1113 #1125

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Jun 10, 2024

In the fix for #1113:

if the URL is at beginning of the sentence/paragraph, it's normal to have both pos and matchingPosition.start) == 0, which should not cause any trouble (the string before will be empty).

This PR updates the >= with >. 😅

@lfoppiano lfoppiano marked this pull request as ready for review June 10, 2024 05:49
@lfoppiano lfoppiano added this to the 0.8.1 milestone Jun 10, 2024
@coveralls
Copy link

Coverage Status

coverage: 40.787%. remained the same
when pulling c5c924e on bugfix/fix-links-beginning-sent
into 694f0ed on master.

@lfoppiano lfoppiano merged commit c44a755 into master Jun 12, 2024
10 checks passed
@lfoppiano lfoppiano deleted the bugfix/fix-links-beginning-sent branch June 12, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants